Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing this code be compatiable with v2.x I also added some comments … #676

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

nicholas-a-clark
Copy link
Contributor

@nicholas-a-clark nicholas-a-clark commented Oct 30, 2020

…and moved variable declarations to the top to clean up the code a bit

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

…and moved variable declarations to the top to clean up the code a bit
@gitwave gitwave bot added the untriaged label Oct 30, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a PR! I've left some feedback for some small changes

examples/hubot-example/script.js Outdated Show resolved Hide resolved
examples/hubot-example/script.js Outdated Show resolved Hide resolved
examples/hubot-example/script.js Outdated Show resolved Hide resolved
examples/hubot-example/script.js Outdated Show resolved Hide resolved
examples/hubot-example/script.js Show resolved Hide resolved
@stevengill stevengill added enhancement M-T: A feature request for new functionality and removed untriaged labels Oct 30, 2020
@stevengill stevengill assigned stevengill and unassigned stevengill Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #676 (d7a3ac3) into main (891b209) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files           8        8           
  Lines         693      693           
  Branches      206      206           
=======================================
  Hits          585      585           
  Misses         71       71           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891b209...d7a3ac3. Read the comment docs.

@nicholas-a-clark
Copy link
Contributor Author

Thanks for sending a PR! I've left some feedback for some small changes

@stevengill I created another pull request with your suggested updates to my code.

@nicholas-a-clark
Copy link
Contributor Author

@stevengill all changes suggested have been committed

@seratch
Copy link
Member

seratch commented Nov 12, 2020

Looks good to me. @stevengill can you take a look at this again?

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevengill stevengill merged commit ca732ea into slackapi:main Nov 12, 2020
@stevengill stevengill added the docs M-T: Documentation work only label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants