added migration guide for v3 #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v3 #745 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 9 9
Lines 849 849
Branches 263 263
=======================================
Hits 653 653
Misses 146 146
Partials 50 50 Continue to review full report at Codecov.
|
aoberoi
suggested changes
Jan 12, 2021
.github/workflows/ci-build.yml
Outdated
| @@ -16,7 +16,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [10.x, 12.x, 14.x] | |||
| node-version: [12.x, 14.x] | |||
There was a problem hiding this comment.
do we want to add 15.x? its known as the current stable (despite not being LTS), so we should likely run tests against it.
There was a problem hiding this comment.
Yeah, probably a good idea.
Co-authored-by: Ankur Oberoi <aoberoi@gmail.com>
seratch
reviewed
Jan 12, 2021
aoberoi
approved these changes
Jan 12, 2021
seratch
added a commit
to seratch/bolt-js
that referenced
this pull request
Jan 12, 2021
stevengill
pushed a commit
that referenced
this pull request
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a migration guide for users upgrading to
@slack/bolt@3.x. Fixes #743Requirements (place an
xin each[ ])