Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation to AWS Lambda deployment guide #798

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 15, 2021

Summary

This pull request adds Japanese translation version to AWS Deployment Guide.

Requirements (place an x in each [ ])

@seratch seratch added the docs M-T: Documentation work only label Feb 15, 2021
@seratch seratch self-assigned this Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #798 (b750bbe) into main (3f7c25c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   65.24%   65.24%           
=======================================
  Files          11       11           
  Lines        1082     1082           
  Branches      320      320           
=======================================
  Hits          706      706           
  Misses        317      317           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7c25c...a86d740. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented Feb 16, 2021

TODO: Update this PR to reflect #800 changes

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇯🇵🎉


まず、サイドバーの「**Interactivity & Shortcuts**」を選択し、**リクエスト URL** を更新します。

![「Interactivity & Shortcuts」ページ](../assets/interactivity-and-shortcuts-page.png "「Interactivity & Shortcuts」ページ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seratch do we want to include translated images as well? Or, is Slack's App Settings page only available in english?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The admin pages are only in English. Therefore, we can reuse the screenshots.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, good to know!

@seratch
Copy link
Member Author

seratch commented Feb 16, 2021

TODO: #801

@seratch seratch merged commit 355f8ef into slackapi:main Feb 17, 2021
@seratch seratch deleted the aws-lambda-deployment-ja branch February 17, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants