Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates docs and examples about deploying to AWS Lambda #800

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

januswel
Copy link
Contributor

Summary

Update docs and examples to follow deprecation of aws-serverless-express

This PR fixes #799

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #800 (5c236f7) into main (e554d27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   65.24%   65.24%           
=======================================
  Files          11       11           
  Lines        1082     1082           
  Branches      320      320           
=======================================
  Hits          706      706           
  Misses        317      317           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e554d27...16cdfee. Read the comment docs.

@seratch seratch added docs M-T: Documentation work only and removed untriaged labels Feb 16, 2021
@seratch
Copy link
Member

seratch commented Feb 16, 2021

At a glance, the changes look great to me but I would like to have @mwbrooks (the author of this guide)'s eyes first.

@januswel
Copy link
Contributor Author

Thank you for your review, @seratch
And your Japanese translation is very easy to read 👍

@mwbrooks
Could you take a look at this PR?

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @januswel for updating our guide to match the latest developments of Serverless Express! 🙇🏻

Your updates look solid and thorough to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs to deploy to AWS Lambda have deprecated descriptions
3 participants