Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description about processBeforeResponse in Reference document #836

Merged
merged 1 commit into from Mar 18, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 18, 2021

Summary

The processBeforeResponse option is not only for Events API. Also, it's not about the automatic acknowledgement.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only labels Mar 18, 2021
@seratch seratch self-assigned this Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #836 (fecab0d) into main (1968af4) will not change coverage.
The diff coverage is n/a.

❗ Current head fecab0d differs from pull request most recent head 42b186e. Consider uploading reports for the commit 42b186e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files          13       13           
  Lines        1173     1173           
  Branches      343      343           
=======================================
  Hits          773      773           
  Misses        334      334           
  Partials       66       66           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1968af4...42b186e. Read the comment docs.

@seratch seratch merged commit ebc90bf into slackapi:main Mar 18, 2021
@seratch seratch deleted the reference-doc-2 branch March 18, 2021 20:40
@seratch seratch added this to the 3.4.0 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants