Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for App#command regex support #847

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

itowlson
Copy link
Contributor

Summary

Provides documentation for #846.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #847 (c470019) into main (0bb1fb2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files          13       13           
  Lines        1207     1207           
  Branches      356      356           
=======================================
  Hits          799      799           
  Misses        338      338           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb1fb2...c470019. Read the comment docs.

@seratch seratch added docs M-T: Documentation work only and removed untriaged labels Mar 23, 2021
@seratch seratch modified the milestones: 3.3.1, 3.4.0 Mar 23, 2021
@seratch seratch mentioned this pull request Mar 23, 2021
10 tasks
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for matching the warning pattern we've used in other parts of the docs!

seratch added a commit to seratch/bolt-js that referenced this pull request Mar 24, 2021
@seratch seratch marked this pull request as draft March 24, 2021 04:49
@seratch seratch marked this pull request as ready for review June 4, 2021 09:10
@seratch seratch merged commit c02c170 into slackapi:main Jun 4, 2021
seratch added a commit that referenced this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants