Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA-JP user.id error #887

Merged
merged 1 commit into from
Apr 15, 2021
Merged

JA-JP user.id error #887

merged 1 commit into from
Apr 15, 2021

Conversation

shaydewael
Copy link
Contributor

Summary

Fix user.id error in Japanese docs (same as #886)

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #887 (73df764) into main (b80422a) will not change coverage.
The diff coverage is n/a.

❗ Current head 73df764 differs from pull request most recent head 03a5257. Consider uploading reports for the commit 03a5257 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   66.11%   66.11%           
=======================================
  Files          13       13           
  Lines        1201     1201           
  Branches      354      354           
=======================================
  Hits          794      794           
  Misses        338      338           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80422a...03a5257. Read the comment docs.

@shaydewael shaydewael added docs M-T: Documentation work only and removed untriaged labels Apr 15, 2021
@seratch seratch merged commit 22f938e into slackapi:main Apr 15, 2021
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @shaydewael. I should have remembered to add this update 🤦🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants