Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reference to reflect value described for processBeforeResponse #967

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

harunsmrkovic
Copy link
Contributor

@harunsmrkovic harunsmrkovic commented Jun 15, 2021

Summary

Reference Docs explain what is processBeforeResponse, but then say that value used to accomplish this is false. However, if you want to ensure that "event listeners don't unexpectedly terminate", you must set this value to true.

This is also visible in the AWS Lambda docs: https://slack.dev/bolt-js/deployments/aws-lambda#prepare-the-app

Requirements

@gitwave gitwave bot added the untriaged label Jun 15, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2021

CLA assistant check
All committers have signed the CLA.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only and removed untriaged labels Jun 15, 2021
@seratch seratch added this to the 3.5.0 milestone Jun 15, 2021
@seratch
Copy link
Member

seratch commented Jun 15, 2021

Hi @harunsmrkovic, thanks for pointing this out. You are right. The document had been incorrect 🙇

@seratch seratch merged commit bc1d6f2 into slackapi:main Jun 15, 2021
seratch added a commit that referenced this pull request Jun 15, 2021
@harunsmrkovic harunsmrkovic deleted the patch-1 branch June 16, 2021 08:13
@stevengill stevengill modified the milestones: 3.5.0, 3.4.1 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants