Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 typo #993

Merged
merged 1 commit into from
Jul 7, 2021
Merged

fix: 🐛 typo #993

merged 1 commit into from
Jul 7, 2021

Conversation

75asa
Copy link
Contributor

@75asa 75asa commented Jul 7, 2021

Summary

fix chore typo

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Jul 7, 2021
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2021

CLA assistant check
All committers have signed the CLA.

@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch and removed untriaged labels Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #993 (b3e1eb7) into main (128ec42) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head b3e1eb7 differs from pull request most recent head d6e225f. Consider uploading reports for the commit d6e225f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   66.25%   66.41%   +0.16%     
==========================================
  Files          13       13              
  Lines        1212     1212              
  Branches      357      357              
==========================================
+ Hits          803      805       +2     
+ Misses        339      338       -1     
+ Partials       70       69       -1     
Impacted Files Coverage Δ
src/conversation-store.ts 100.00% <100.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 128ec42...d6e225f. Read the comment docs.

@mwbrooks
Copy link
Member

mwbrooks commented Jul 7, 2021

Hi @75asa 👋🏻 Welcome to the Bolt JS project and thanks for signing the CLA!

This 🐛 is a great catch. The patch looks good to me ✅

@mwbrooks mwbrooks merged commit 2af66a2 into slackapi:main Jul 7, 2021
@75asa 75asa deleted the 75asa/fix/typo branch July 8, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants