You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! I'm new to using Bolt and Slack in general.
Been scratching my head over why my custom receiver was not working, and when I looked at the source code in src/App.tsx I noticed this:
if (signingSecret !== undefined) {
this.receiver = new ExpressReceiver({ signingSecret, endpoints }); this.receiver = new ExpressReceiver({ signingSecret, logger, endpoints });
} else if (receiver === undefined) { }
So I commented out the SigningSecret that I was previously passing and it worked!
I think the application should either not overwrite the passed receiver, or log a warning in this scenario.
What type of issue is this? (place an x in one of the [ ])
bug
enhancement (feature request)
question
documentation related
testing related
discussion
Requirements (place an x in each of the [ ])
I've read and understood the Contributing guidelines and have done my best effort to follow them.
I definitely agree that Bolt shouldn't override the passed in receiver. This seems like a bug to me as the constructor should be checking if signingSecret is defined and receiver is undefined
shaydewael
added
the
bug
M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
label
Aug 19, 2019
Description
Hi! I'm new to using Bolt and Slack in general.
Been scratching my head over why my custom receiver was not working, and when I looked at the source code in
src/App.tsx
I noticed this:So I commented out the SigningSecret that I was previously passing and it worked!
I think the application should either not overwrite the passed receiver, or log a warning in this scenario.
What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version: 1.2.0
node version: 12.6.0
OS version(s): Windows 10 Pro
Steps to reproduce:
Expected result:
Bolt doesn't overwrite my receiver with the ExpressReceiver
Actual result:
Bolt overwrites my receiver with the ExpressReceiver
Attachments:
https://github.com/slackapi/bolt/blob/522e70b381cf3d18a88b7ca271dcfb4f0ce1be9b/src/App.ts#L161
The text was updated successfully, but these errors were encountered: