Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUERY] Warning about External Teams #323

Open
markfoden opened this issue May 22, 2024 · 11 comments
Open

[QUERY] Warning about External Teams #323

markfoden opened this issue May 22, 2024 · 11 comments
Labels
question Further information is requested semver:patch requires a patch version number bump

Comments

@markfoden
Copy link

@filmaj I've just started getting warnings about external teams when running an app:

Screenshot 2024-05-22 at 13 40 31

It says the remedy is to "remove external teams in Settings" but I don't know what is meant by "Settings" - there seems to be nothing in the app referring to external teams.

Could you help please?

@markfoden markfoden changed the title [QUERY] <title> [QUERY] Warning about External Teams May 22, 2024
@filmaj
Copy link
Contributor

filmaj commented May 22, 2024

Hmm, odd, that remediation text certainly needs some work.

To make sure I understand the situation: what are the first and second steps you are using in allocate_workflow and no_partner_found_workflow ?

@filmaj
Copy link
Contributor

filmaj commented May 22, 2024

And now for your context: "External teams" implies usage of Slack Connect channels, channels that are shared/connected between multiple different workspaces (possibly from outside your organization). There are workspace/organization administrator settings that enable admins to restrict specific workflow steps from being used by 'external teams' - that is, users from workspaces that are not part of your workspace but that are members of these shared channels.

@markfoden
Copy link
Author

@filmaj As an example here are the steps for allocate_workflow - the other is pretty much the same:

Screenshot 2024-05-22 at 14 15 20

Step One retrieves some data from a CRM and Step Two runs a modal function

@markfoden
Copy link
Author

And now for your context: "External teams" implies usage of Slack Connect channels, channels that are shared/connected between multiple different workspaces (possibly from outside your organization). There are workspace/organization administrator settings that enable admins to restrict specific workflow steps from being used by 'external teams' - that is, users from workspaces that are not part of your workspace but that are members of these shared channels.

I've found this in Slack settings but there's no mention of external teams
Screenshot 2024-05-22 at 14 35 51
Am I looking in the right place?

@markfoden
Copy link
Author

Generally though it sounds like the warning is not critical for us as we don't need any external users to use the workflow steps. Can I safely ignore it?

@filmaj
Copy link
Contributor

filmaj commented May 22, 2024

Correct, if the command didn't error out, it is just informing you "hey users that are not members of the workspace this app was installed to will be unable to use this workflow."

Let me follow up on the exact settings that are mentioned here so that you have the relevant info, and then we'll discuss with the team how to clarify the warning message raised by the CLI in this case.

@filmaj
Copy link
Contributor

filmaj commented May 22, 2024

OK, found the info: https://slack.com/help/articles/14844871922195-Slack-administration--Manage-workflow-usage-in-Slack-Connect-conversations#enterprise-grid-1

The relevant bits are:

To protect your organization, external people in Slack Connect conversations can never use a workflow that contains the following:

I'm going to keep this issue open until we figure out a better way of communicating this situation in the CLI warning repsonse.

@filmaj filmaj added question Further information is requested semver:patch requires a patch version number bump labels May 22, 2024
@mcsescott
Copy link

I started seeing the same thing within the last two days (may have been when I updated the CLI/deno-sdk from slack doctor), and I opened a feedback request on it.

This was their response:

In the context of your app, the warning indicates that external people will not be able to use the custom step you are building.

I do agree that the message is somewhat confusing and this has been flagged with our engineering team. However, it shouldn't impact anything besides who can run the workflow.

As @filmaj stated, this does not affect running the app; it is just a warning. In large organizations such as mine, this is a problem, but I will work through it in other channels/methods.

@benjrich-jasper
Copy link

I am also seeing these warnings for all 130+ steps in our app, so it's very noisy and takes a full year to scroll through 😅

Is there a way to silence these warnings for the time being? Maybe using a cli flag?

@yoniamir
Copy link

Same issue here. These warnings are quite noisy and hurt the developer experience, especially without any clear guidance on how to resolve them.
CleanShot 2024-05-28 at 19 09 42@2x
(workflow names redacted)

@filmaj
Copy link
Contributor

filmaj commented May 30, 2024

FYI today's CLI release (v2.25.0) should somewhat address, at least, how much real estate these warnings take up by grouping the same warnings together.

After speaking to different teams internally at Slack, we decided to have the underlying App Manifest APIs that return this warning maintain the warning, as it is contextually relevant for teams and this warning also shows up in Workflow Builder if you build a workflow that way.

We are also debating maybe limiting the number of warnings that end up being displayed (to, say, 5) in an effort to further declutter the CLI's output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested semver:patch requires a patch version number bump
Projects
None yet
Development

No branches or pull requests

5 participants