Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests not to be affected by env variables #591

Open
2 of 6 tasks
seratch opened this issue Oct 15, 2020 · 0 comments
Open
2 of 6 tasks

Improve unit tests not to be affected by env variables #591

seratch opened this issue Oct 15, 2020 · 0 comments
Assignees
Labels
enhancement M-T: A feature request for new functionality project:bolt
Milestone

Comments

@seratch
Copy link
Member

seratch commented Oct 15, 2020

Some of the unit tests for Bolt modules may fail when the host has some env variables such as SLACK_CLIENT_ID, SLACK_CLIENT_SECRET, and so on. We can improve it to be more stable regardless of the external factors.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. 🙇

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt labels Oct 15, 2020
@seratch seratch added this to the 1.x milestone Oct 15, 2020
@seratch seratch self-assigned this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt
Projects
None yet
Development

No branches or pull requests

1 participant