Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodsClientImpl is difficult to subclass #75

Closed
joeltoby opened this issue Jul 23, 2018 · 1 comment
Closed

MethodsClientImpl is difficult to subclass #75

joeltoby opened this issue Jul 23, 2018 · 1 comment

Comments

@joeltoby
Copy link
Contributor

MethodsClientImpl implements over 130 API methods from the MethodsClient interface. Each of these methods in turn invokes one of three private doPost... methods.

I would like to extend MethodsClientImpl within my project to add some custom rate limiting, but this would require overriding each of the 130+ methods (as the private doPost... methods cannot be overridden).

Changing the access modifiers on the three doPost methods from private to protected would make it much easier for clients to write custom MethodsClient implementations.

@joeltoby
Copy link
Contributor Author

I actually solved my custom Rate Limiting issue a different way, but I still think this change would make extending the MethodsClient easier for other clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant