Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InstallationStore design to use two callbacks instead of four #1133

Closed
5 tasks done
stevengill opened this issue Dec 9, 2020 · 0 comments
Closed
5 tasks done
Labels
enhancement M-T: A feature request for new functionality pkg:oauth applies to `@slack/oauth-helper` semver:major

Comments

@stevengill
Copy link
Member

Description

With the introduction of Org Wide Apps, we introduced two new methods to our @slack/oauth installationStore to support this. fetchOrgInstall & saveOrgInstall were added to the installationStore definition, which already included fetchInstall & saveInstall.

With us coming up to releasing a new major, now is a good time to revisit this design and bring it in line with our other libraries that only support the original two callbacks in installationStore for both single workspace and org wide app installs. So we want to drop support for fetchOrgInstall and saveOrgInstall.

This would be a breaking change.

What type of issue is this? (place an x in one of the [ ])

  • enhancement (feature request)

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Packages:

  • @slack/oauth
@stevengill stevengill added semver:major enhancement M-T: A feature request for new functionality pkg:oauth applies to `@slack/oauth-helper` labels Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:oauth applies to `@slack/oauth-helper` semver:major
Projects
None yet
Development

No branches or pull requests

1 participant