Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken url caused by typo #1160

Merged
merged 1 commit into from Jan 19, 2021
Merged

Fix broken url caused by typo #1160

merged 1 commit into from Jan 19, 2021

Conversation

saintmalik
Copy link
Contributor

Summary

Easy navigation and easy reading for others

## Summary

Easy navigation and easy reading for others
@gitwave gitwave bot added the untriaged label Jan 19, 2021
@mwbrooks mwbrooks added docs M-T: Documentation work only and removed untriaged labels Jan 19, 2021
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @saintmalik, great catch and thanks for your first-time contribution! 🎉

I see you've already signed the CLA 🙇🏻 so I'll merge and deploy this change shortly. But first, I'll deal with the failing test that's blocking the merge - this isn't your fault, we've recently switched our CI environment and are experiencing a few sporadic failures.

@saintmalik
Copy link
Contributor Author

Hey @saintmalik, great catch and thanks for your first-time contribution! 🎉

I see you've already signed the CLA 🙇🏻 so I'll merge and deploy this change shortly. But first, I'll deal with the failing test that's blocking the merge - this isn't your fault, we've recently switched our CI environment and are experiencing a few sporadic failures.

Thanks @mwbrooks, okay no problem

@mwbrooks mwbrooks merged commit 894ed0a into slackapi:main Jan 19, 2021
@mwbrooks
Copy link
Member

@saintmalik merged and deployed! :shipit:

Thanks again for the improvement to our docs:
https://slack.dev/node-slack-sdk/web-api#handle-errors

@saintmalik
Copy link
Contributor Author

@saintmalik merged and deployed! :shipit:

Thanks again for the improvement to our docs:
https://slack.dev/node-slack-sdk/web-api#handle-errors

You are welcome, am happy to contribute anyway😌😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants