[socket-mode] Pass an agent to WebSocket in a proper way

[g12i]

Summary

Fix passing an agent to WebSocket. this.clientOptions.agent was wrongly spread to WebSocket options, which effectively mean it wasn't used.

Requirements (place an x in each [ ])

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[mwbrooks]

Hey @g12i, thanks for catching this issue and sending a patch! I've added a couple reviewers, so someone will pick up it up shortly to confirm the bug and review the work.

If you have some time, I think we should also consider adding a test to prevent regression. :)

[g12i]

Hey @mwbrooks - trust me this is the first thing I wanted to do :)

PS C:\Users\wgrze\Projects\node-slack-sdk\packages\socket-mode> npm run test

> @slack/socket-mode@1.0.0 test C:\Users\wgrze\Projects\node-slack-sdk\packages\socket-mode
> npm run build && echo "Tests are not implemented." && exit 0


> @slack/socket-mode@1.0.0 build C:\Users\wgrze\Projects\node-slack-sdk\packages\socket-mode
> npm run build:clean && tsc


> @slack/socket-mode@1.0.0 build:clean C:\Users\wgrze\Projects\node-slack-sdk\packages\socket-mode
> shx rm -rf ./dist

"Tests are not implemented."

I see mocha in some packages but it's not defined in the root package.json. And I don't know the project well enough to build the test setup myself.

[mwbrooks]

@g12i oops, my bad! SocketMode is hot off the press and don't have specs written for it yet. We've been looking into a reliable way to run non-integration tests and will most likely draw inspiration from the SocketMode tests for Bolt Python and Java.

[stevengill]

Thanks for catching this!