New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timepicker to @slack/types #1226
Conversation
Hi @raycharius, thanks for taking the time to make this PR! The current revision seems to have a lint error. Can you fix the error?
Apart from that, the changes look good to me. For the timing to merge this, I have been holding off adding timepicker in the Python SDK as it's still in a developer beta. See slackapi/python-slack-sdk#876 for the context. However, the beta has been taking longer than I expect and even now, I cannot tell when the GA release will come yet. Therefore, I'm leaning toward merging the changes. If the CI failure is fixed, we are happy to merge the change. Also, thanks for bringing the further suggestions! As I would like to make this PR's scope as small as possible, I will create a new issue for discussing other improvements. Let's discuss them separately! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CI build is failing
Oops! Fixed. It's a bit ugly and hard to read with that union type on each line in the actual interface, but easily fixed if proposals for moving union types to their own exported type |
Summary
Noticed that @slack/types does not include an interface for the time picker block element. Added it and included it in all of the corresponding union types.
Also, I think there are some opportunities for refactoring that would make this package even more useful than it already is. While developing v.2 of slack-block-builder, I've noticed I'm doing a lot of typing on my end, since a lot of the types aren't available through this package.
ActionsBlock
having a type ofActionsElements
. ForSectionBlock
,SectionElements
. Etc.Happy to take a shot at that, too, and send over a PR, if that's something you could see in the scope here.
Cheers!
Requirements (place an
x
in each[ ]
)