Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update apps.connections.open API response type in SocketModeClient #1234

Merged
merged 1 commit into from May 19, 2021
Merged

Update apps.connections.open API response type in SocketModeClient #1234

merged 1 commit into from May 19, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented May 12, 2021

Summary

This pull request updates the Web API response type that SocketModeClient returns in its start() method. As with slackapi/bolt-js#915, the new type inherits the WebAPICallResult interface. Thus, the change in this PR is backward-compatible.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects pkg:socket-mode applies to `@slack/socket-mode` labels May 12, 2021
@seratch seratch added this to the socket-mode@1.1 milestone May 12, 2021
@seratch seratch self-assigned this May 12, 2021
@mwbrooks mwbrooks mentioned this pull request May 12, 2021
Merged
2 tasks
@seratch seratch merged commit 80deced into slackapi:main May 19, 2021
@seratch seratch deleted the socket-mode-api-response branch May 19, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@stevengill stevengill Awaiting requested review from stevengill

Assignees

@seratch seratch

Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality pkg:socket-mode applies to `@slack/socket-mode`
Projects
None yet
Milestone
socket-mode@1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seratch @mwbrooks