Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deleteInstallation optional #1273

Merged
merged 1 commit into from Jun 18, 2021
Merged

Make deleteInstallation optional #1273

merged 1 commit into from Jun 18, 2021

Conversation

misscoded
Copy link
Contributor

Summary

Post-merge feedback pointed out that deleteInstallation not being optional will cause issues for folks that have introduced their own stores already. Designating it as optional until next major version (v3.0).

Requirements (place an x in each [ ])

@misscoded misscoded added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper` labels Jun 18, 2021
stevengill
stevengill approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix

@misscoded misscoded merged commit 89b1838 into slackapi:main Jun 18, 2021
@seratch seratch added this to the oauth@2.2 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengill stevengill stevengill approved these changes

Assignees
No one assigned
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper` semver:minor
Projects
None yet
Milestone
oauth@2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@misscoded @stevengill @seratch