Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FileStoreInstallation installation directory creation synchronous #1288

Merged
merged 1 commit into from Jul 15, 2021

Conversation

misscoded
Copy link
Contributor

Summary

Fixes issue with error occurring on initial creation of installation directory with FileInstallationStore due to asynchronous nature.

Requirements (place an x in each [ ])

@misscoded misscoded added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper` labels Jul 15, 2021
@misscoded misscoded added this to the oauth@2.2 milestone Jul 15, 2021
@seratch
Copy link
Member

seratch commented Jul 15, 2021

#1289 should resolve the build error

@misscoded misscoded merged commit 1657ae5 into slackapi:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants