Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors in oauth package #1289

Merged
merged 2 commits into from Jul 15, 2021
Merged

Fix lint errors in oauth package #1289

merged 2 commits into from Jul 15, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jul 15, 2021

Summary

The CI builds for the latest revision fails as the latest lslint detects two things in the new code.

Requirements (place an x in each [ ])

@seratch seratch added this to the oauth@2.2 milestone Jul 15, 2021
@seratch seratch requested a review from misscoded July 15, 2021 01:20
@gitwave gitwave bot added the untriaged label Jul 15, 2021
@misscoded misscoded added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper` and removed untriaged labels Jul 15, 2021
@seratch
Copy link
Member Author

seratch commented Jul 15, 2021

Interestingly, Node 14's linter says a different thing. I will update the code to satisfy both (perhaps, the comment to ignore these)

ERROR: /home/runner/work/node-slack-sdk/node-slack-sdk/packages/oauth/src/stores/file-store.ts:93:64 - Unexpected parentheses around single function argument having a body with no curly braces.
ERROR: /home/runner/work/node-slack-sdk/node-slack-sdk/packages/oauth/src/stores/file-store.ts:98:25 - Unexpected parentheses around single function argument having a body with no curly braces.

@seratch
Copy link
Member Author

seratch commented Jul 15, 2021

This is not ideal but I've added comment flags to satisfy all the supported Node runtimes. Let me merge this now.

@seratch seratch merged commit eb28972 into slackapi:main Jul 15, 2021
@seratch seratch deleted the lint-error branch July 15, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants