Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking getting started docs to reflect changes in app setup UI on the application configuration pages #1300

Merged
merged 1 commit into from Aug 3, 2021

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 3, 2021

Summary

It looks like the various app configuration pages on api.slack.com/apps have changed their UI since the Getting Started docs in this project were written. This PR has a few tiny tweaks to the getting started instructions to reflect the changes in the UI.

Also changed the example tutorial code so that the "Message Posted" console.log only runs if no error is raised. Otherwise, in case you hit an error while running the example tutorial code (if you're silly like I was and forgot to invite my bot to the general channel), you could see something like this:

➜ node tutorial.js
Getting started with Node Slack SDK
Error: An API error occurred: not_in_channel
    at Object.platformErrorFromResult (/Users/fmaj/src/slapp-node-web-api/node_modules/@slack/web-api/dist/errors.js:51:33)
    at WebClient.apiCall (/Users/fmaj/src/slapp-node-web-api/node_modules/@slack/web-api/dist/WebClient.js:158:28)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async /Users/fmaj/src/slapp-node-web-api/tutorial.js:11:5 {
  code: 'slack_webapi_platform_error',
  data: {
    ok: false,
    error: 'not_in_channel',
    response_metadata: { scopes: [Array], acceptedScopes: [Array] }
  }
}
Message posted!

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Aug 3, 2021
docs/_main/getting_started.md Outdated Show resolved Hide resolved
@srajiang srajiang added docs M-T: Documentation work only and removed untriaged labels Aug 3, 2021
…p UI on the application configuration pages. Changed example tutorial code so that the Message Posted console.log only runs if no error is raised.
@filmaj filmaj merged commit 0b25a68 into main Aug 3, 2021
@filmaj filmaj deleted the getting-started-tweaks branch August 3, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants