Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable typescript-eslint/no-explicit-any in internal code of web-api #1374

Merged
merged 1 commit into from Nov 8, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 8, 2021

Summary

This pull request disables eslint warnings about the usage of any type in the internal code of web-api package. I think that disabling these should be safe enough.

> @slack/web-api@6.4.0 lint /Users/ksera/github/node-slack-sdk/packages/web-api
> eslint --ext .ts src


/Users/ksera/github/node-slack-sdk/packages/web-api/src/WebClient.ts
   83:34  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  381:48  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  381:62  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  427:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  448:73  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  452:60  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  482:37  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  482:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  511:42  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/node-slack-sdk/packages/web-api/src/errors.ts
  41:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/node-slack-sdk/packages/web-api/src/methods.ts
  2078:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  2081:24  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 12 problems (0 errors, 12 warnings)

Requirements (place an x in each [ ])

@seratch seratch added area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Nov 8, 2021
@seratch seratch added this to the web-api@6.5.0 milestone Nov 8, 2021
@seratch seratch changed the title Disnable typescript-eslint/no-explicit-any in internal code of web-api Disable typescript-eslint/no-explicit-any in internal code of web-api Nov 8, 2021
@seratch seratch merged commit 8b3fb8d into slackapi:main Nov 8, 2021
@seratch seratch deleted the typescript-eslint/no-explicit-any branch November 8, 2021 14:29
@seratch seratch self-assigned this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants