Expose axios timeout parameter for webhooks #1378
Assignees
Labels
enhancement
M-T: A feature request for new functionality
good first issue
pkg:webhook
applies to `@slack/webhook`
Milestone
Comments
tk26
changed the title
seratch
added
enhancement
|
Hi @tk26, thanks for writing in! I agree that this should be a good addition. |
|
that was an ultra-fast response! thanks @seratch - mind if I take a stab at it? |
|
If you are fine to sign our CLA (https://cla-assistant.io/slackapi/node-slack-sdk), a fix with test code (like this way: #1264) would be appreciated! |
|
Great! I just signed the CLA. Will create a fix soon. Thanks @seratch |
2 tasks
|
This issue was resolved after merging #1394. I will cut a webhook@6.1.0 release shortly which will include this new option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By default axios has no timeout, this is a bad default for production systems and currently there is no way to override it.
You can override the socket timeout with the agent but it's not the same thing.
I would like to be able to change that via the WebClient options.
Note: This was added for web-api in #1250
As a part of this issue, it'd be great if we could support webhooks.
Packages:
Select all that apply:
@slack/web-api@slack/rtm-api@slack/webhooks@slack/oauth@slack/socket-modeRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
The text was updated successfully, but these errors were encountered: