Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sub directory for installation stores #1443

Merged
merged 1 commit into from Mar 2, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 2, 2022

Summary

Now that we have state-stores directory for StateStore, renaming stores to installation-stores would be better in terms of consistency.

As long as users import the interface / classes from @slack/oauth, this change does not affect any existing apps. Thus, I don't think that we can this a breaking change. What do you think?

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality pkg:oauth applies to `@slack/oauth-helper` labels Mar 2, 2022
@seratch seratch added this to the oauth@2.5.0 milestone Mar 2, 2022
@seratch seratch requested a review from filmaj March 2, 2022 22:52
@seratch seratch self-assigned this Mar 2, 2022
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is fine. Breaking change would only apply to public APIs; importing specific package source files from sub directories is never recommended for exactly this reason.

@seratch
Copy link
Member Author

seratch commented Mar 2, 2022

@filmaj Thanks for your quick response!

@seratch seratch merged commit 8aa712b into slackapi:main Mar 2, 2022
@seratch seratch deleted the installation-stores branch March 2, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:oauth applies to `@slack/oauth-helper`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants