Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating beta releasing steps for maintainers #1445

Merged
merged 1 commit into from Mar 4, 2022
Merged

Updating beta releasing steps for maintainers #1445

merged 1 commit into from Mar 4, 2022

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Mar 3, 2022

Now uses npm publish --tag and removes the need to invoke npm dist-tag.

@filmaj
Updating beta releasing steps for maintainers to use `npm publish --t…
aabc7c3 
…ag` and remove the need to invoke `npm dist-tag`.
@filmaj filmaj added the docs M-T: Documentation work only label Mar 3, 2022
@filmaj filmaj requested review from seratch and srajiang March 3, 2022 22:13
seratch
seratch approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - applying similar changes to bolt-js project would be appreciated!

srajiang
srajiang approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Glad to be rid of the uncomfortable short period of time between npm publish and updating the dist-tag. I always imagine that person is installing the sdk right in that pocket of time.

@srajiang srajiang mentioned this pull request Mar 4, 2022
Merged
2 tasks
@srajiang
Copy link
Member

srajiang commented Mar 4, 2022

Here you go! slackapi/bolt-js#1348

@seratch seratch merged commit 3a8de9c into main Mar 4, 2022
@seratch seratch deleted the update-maintainers-guide branch March 4, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

@srajiang srajiang srajiang approved these changes

Assignees
No one assigned
Labels
docs M-T: Documentation work only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@filmaj @srajiang @seratch