Adding documentation for handleInstallPath, beforeRedirection, beforeInstallation, afterInstallation #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llPath`), as well as new before/after callbacks (`beforeRedirection`, `beforeInstallation`, `afterInstallation`). Updated the oauth package reference documentation.
filmaj
added
docs
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
|
@filmaj I forgot to mention this in the review comment but we may want to add a new section in https://slack.dev/node-slack-sdk/oauth, which explains how to set custom cookies to the installer browser in |
|
@seratch good idea, will try to add that |
|
@seratch I have added a new section "Persisting data during the OAuth flow" where I hope I was able to depict the example of reading and writing from cookies and using the new callbacks. What do you think? |
seratch
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the oauth package reference documentation (that was pretty out of date)!
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an
xin each[ ])