Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip comments for any type warnings in socket-mode module #1458

Merged
merged 1 commit into from Apr 5, 2022
Merged

Add skip comments for any type warnings in socket-mode module #1458

merged 1 commit into from Apr 5, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 5, 2022

Summary

Since we are not planning to change the types in the short term, we can add skip comments for the any-type-usage warnings.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality pkg:socket-mode applies to `@slack/socket-mode` labels Apr 5, 2022
@seratch seratch added this to the socket-mode@1.3.0 milestone Apr 5, 2022
@seratch seratch self-assigned this Apr 5, 2022
@seratch seratch merged commit f666158 into slackapi:main Apr 5, 2022
@seratch seratch deleted the any-warnings branch April 6, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmaj filmaj filmaj approved these changes

@srajiang srajiang srajiang approved these changes

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality pkg:socket-mode applies to `@slack/socket-mode`
Projects
None yet
Milestone
socket-mode@1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seratch @filmaj @srajiang