Add envelope_id to Socket Mode listener arguments #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
2 tasks
filmaj
approved these changes
Apr 14, 2022
and thanks for expanding the tests!
seratch
changed the title
mwbrooks
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enhances the payload data to have
envelope_idfor all listeners.The motivation that I would like to add this property is for better debug-level logging on the bolt-js side. In most cases, developers do not need to directly use
envelope_idas theack()method does everything for you. However, the libraries built on top of@slack/socket-modemay want to use the property for logging and so on.Requirements (place an
xin each[ ])