Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Message Metadata support #1504

Merged
merged 3 commits into from Jul 4, 2022
Merged

Adding Message Metadata support #1504

merged 3 commits into from Jul 4, 2022

Conversation

dannyhostetler
Copy link
Contributor

Summary

This PR introduces support for Slack's latest Message Metadata feature. A new type "MessageMetadata" is introduced and additionally adding an optional "metadata" argument on ChatPostMessageArguments, ChatScheduleMessageArguments and ChatUpdateArguments.

Requirements (place an x in each [ ])

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I added one additional change request. Can you check it out if you have a chance?

@@ -1460,6 +1462,7 @@ export interface ChatUpdateArguments extends WebAPICallOptions, TokenOverridable
attachments?: MessageAttachment[];
blocks?: (KnownBlock | Block)[];
link_names?: boolean;
metadata?: MessageMetadata;
parse?: 'full' | 'none';
file_ids?: string[];
reply_broadcast?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add include_all_metadata parameter to conversations.history API too? https://api.slack.com/methods/conversations.history#arg_include_all_metadata

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is done 👍

@seratch seratch added this to the types@2.6.0 milestone Jul 1, 2022
@seratch seratch added pkg:types applies to `@slack/types` enhancement M-T: A feature request for new functionality labels Jul 1, 2022
@seratch seratch requested review from filmaj and srajiang July 1, 2022 01:56
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2022

CLA assistant check
All committers have signed the CLA.

@seratch
Copy link
Member

seratch commented Jul 1, 2022

@dannyhostetler Would you mind signing the CLA? Please check the bot message above.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seratch seratch merged commit fe0a62b into slackapi:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants