New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Message Metadata support #1504
Adding Message Metadata support #1504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I added one additional change request. Can you check it out if you have a chance?
@@ -1460,6 +1462,7 @@ export interface ChatUpdateArguments extends WebAPICallOptions, TokenOverridable | |||
attachments?: MessageAttachment[]; | |||
blocks?: (KnownBlock | Block)[]; | |||
link_names?: boolean; | |||
metadata?: MessageMetadata; | |||
parse?: 'full' | 'none'; | |||
file_ids?: string[]; | |||
reply_broadcast?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add include_all_metadata
parameter to conversations.history API too? https://api.slack.com/methods/conversations.history#arg_include_all_metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this is done 👍
@dannyhostetler Would you mind signing the CLA? Please check the bot message above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR introduces support for Slack's latest Message Metadata feature. A new type "MessageMetadata" is introduced and additionally adding an optional "metadata" argument on ChatPostMessageArguments, ChatScheduleMessageArguments and ChatUpdateArguments.
Requirements (place an
x
in each[ ]
)