Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate @slack/client if it's flagged as legacy? #1508

Closed
jimmywarting opened this issue Jul 6, 2022 · 5 comments
Closed

deprecate @slack/client if it's flagged as legacy? #1508

jimmywarting opened this issue Jul 6, 2022 · 5 comments
Assignees
Labels
auto-triage-stale pkg:client (deprecated) applies to `@slack/client` question M-T: User needs support to use the project

Comments

@jimmywarting
Copy link
Contributor

if @slack/client is marked as legacy, should you deprecate it then?
See how: https://docs.npmjs.com/cli/v8/commands/npm-deprecate

@jimmywarting jimmywarting changed the title deprecate @slack/client if it's flagged as legacy? deprecate @slack/client if it's flagged as legacy? Jul 6, 2022
@mwbrooks mwbrooks added question M-T: User needs support to use the project pkg:client (deprecated) applies to `@slack/client` and removed untriaged labels Jul 6, 2022
@mwbrooks
Copy link
Member

mwbrooks commented Jul 6, 2022

Hey @jimmywarting, that's a great suggestion and I'm a little surprised that we overlooked it! I'm going to loop in a few teammates/maintainers to double-check that there wasn't a reason why we didn't mark the npm package as deprecated.

@stevengill @seratch Do you know if there's a reason why we haven't marked this package as deprecated in package.json?

@seratch
Copy link
Member

seratch commented Jul 6, 2022

@mwbrooks I am sure that there is no blocker for marking the package deprecated.

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.

@jimmywarting
Copy link
Contributor Author

still not deprecated...

@hello-ashleyintech
Copy link
Contributor

I have deprecated the @slack/client package and have a PR open to update the package's README to reflect its deprecation. I'll close this issue out once the PR to update the README is added in. 🙌 Thanks again for the awesome suggestion, @jimmywarting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-triage-stale pkg:client (deprecated) applies to `@slack/client` question M-T: User needs support to use the project
Projects
None yet
Development

No branches or pull requests

4 participants