Added in functionality for admin.analytics.getFile method #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello-ashleyintech
added
enhancement
…o decode response
filmaj
requested changes
Jul 21, 2022
…re explicit, updated unzip logic and buildResult to be async, added in interface types for responses, updated code_generator script to skip auto generation of AdminAnalyticsGetFile
filmaj
approved these changes
Jul 21, 2022
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| import { WebAPICallResult } from '../WebClient'; | |||
| export type AdminAnalyticsGetFileResponse = WebAPICallResult & { | |||
| file_data?: Array<MemberDetails|PublicChannelDetails|PublicChannelMetadataDetails>[]; | |||
seratch
requested changes
Jul 21, 2022
…ated code generation script to account for admin analytics, fixed some spacing, added in a TODO for future improvement for error handling
seratch
approved these changes
Jul 21, 2022
|
Okay, this PR is ready to merge. Thanks for adding this feature! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding in
admin.analytics.getFilesupport as mentioned in: #1191Link to docs for the method is here: https://api.slack.com/methods/admin.analytics.getFile. This method is a little more unique to other methods -
okproperty to note its success. Due to the successful response being binary, it needs to be sent as an ArrayBuffer response to be able to be parsed properly - this was also added in this PR{ ok: false, error: "error message" }Tested this functionality + tests locally on my own enterprise grid account.
Requirements (place an
xin each[ ])