Always handle web socket open when connecting #1522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should resolve #1521
An edge case seem to be present when the
finite state machine (fns)
is not in the authenticated state and the listeners are initialized. This can happen when the application was connected (initialized), lost connection and is reconnecting.If for some reason the
web socket open
event is triggered before authentication is successful thefns
falls-back to handling this event at theconnecting
state level instead of thesubmachine
. This causes anfns
error which terminates the running process.This pr changes the behavior of the
fns
to ignoreweb socket open
events when it is in theconnecting
state and the submachine is notauthenticated
, this should prevent the process from terminating.Requirements (place an
x
in each[ ]
)