Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactivity pointer #1526

Conversation

hello-ashleyintech
Copy link
Contributor

Summary

Events like block_action, views_* events that are sent with interactivity payloads aka (function, function_data) will no longer contain trigger_id but instead a new field called interactivity_pointer. The motivation is to move away from the legacy term "trigger" as it doesn't actually refer to the 2.0 concept of trigger.

This doesn't affect those same events if they are not sent with interactivity payload data (aka regular 1.0 block actions and views events), so there shouldn't be an impact on existing devs / apps.

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech added docs M-T: Documentation work only enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` draft labels Aug 29, 2022
@hello-ashleyintech hello-ashleyintech self-assigned this Aug 29, 2022
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay thanks for tackling this! Left some comments for ya.

docs/_packages/web_api.md Outdated Show resolved Hide resolved
@hello-ashleyintech hello-ashleyintech marked this pull request as ready for review September 6, 2022 17:56
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Some documentation comment suggestions here to wrap up, but the changes to the types are looking good to me.

Let's branch next-gen off main and point this branch to merge to that. That way we'll be all set up for cutting the beta release of web-api.

docs/_packages/web_api.md Outdated Show resolved Hide resolved
docs/_packages/web_api.md Outdated Show resolved Hide resolved
docs/_packages/web_api.md Outdated Show resolved Hide resolved
packages/web-api/src/methods.ts Show resolved Hide resolved
@hello-ashleyintech hello-ashleyintech changed the base branch from main to next-gen September 9, 2022 15:03
@hello-ashleyintech hello-ashleyintech changed the base branch from next-gen to main September 9, 2022 15:04
@hello-ashleyintech hello-ashleyintech changed the base branch from main to next-gen September 9, 2022 15:05
@hello-ashleyintech hello-ashleyintech merged commit aa0c2fd into slackapi:next-gen Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants