Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lerna dependency #1532

Merged
merged 4 commits into from Sep 8, 2022
Merged

Bump lerna dependency #1532

merged 4 commits into from Sep 8, 2022

Conversation

srajiang
Copy link
Member

@srajiang srajiang commented Sep 7, 2022

Summary

Lerna is officially not actively maintained, and as far as I can tell it isn't used at the individual package level - each package maintains it's own tests.

Lerna ownership was handed over to a corp sponsor! I've bumped the version.

This change removes bumps this dependency.

Requirements (place an x in each [ ])

@srajiang srajiang self-assigned this Sep 7, 2022
@srajiang srajiang added the tests M-T: Testing work only label Sep 7, 2022
Copy link
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: The only note historically that prevented this from occurring sooner (that I could find) was this.

So, should be good to go if that's a non-issue!

@srajiang srajiang changed the title Remove lerna dependency Bump lerna dependency Sep 7, 2022
@srajiang
Copy link
Member Author

srajiang commented Sep 7, 2022

@misscoded! Good call out - on further investigation, looks like lerna active maintenance got handed over to an official corporate sponsor, and they do have a recent version out, whoops. I've changed up the PR to bump the dependency instead. If that sounds good to you, I will merge.

@misscoded
Copy link
Contributor

Sounds fine to me but why keep it around if we're not using it? Did it in fact cause issues with the CI/CD stuff?

@srajiang
Copy link
Member Author

srajiang commented Sep 8, 2022

Spot on - so based on the CI/CD summary, we are using it to build all the packages and run some tests (I am not sure if it runs all tests of each package though) for CI/CD only. Keeping that around seems like a good thing.

@srajiang srajiang merged commit 711e1f9 into main Sep 8, 2022
@srajiang srajiang deleted the remove-lerna-dep branch September 8, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants