Factor out confirm, placeholder, focus_on_load and dispatch_action_config properties
#1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to own interfaces that other elements extend from. Factor out `dispatch_action_config` property into own extendable interface.
filmaj
added
question
filmaj
requested review from
seratch,
mwbrooks,
stevengill,
misscoded,
hello-ashleyintech,
zimeg,
WilliamBergamin and
srajiang
filmaj
commented
Oct 28, 2022
| placeholder?: PlainTextElement; | ||
| } | ||
|
|
||
| export interface Dispatchable { |
There was a problem hiding this comment.
Right now only one element uses this interface, but if/when we merge #1549, then the new input elements like URL, email and number inputs will also use this interface.
WilliamBergamin
approved these changes
Oct 28, 2022
srajiang
requested changes
Oct 28, 2022
packages/types/src/index.ts
Outdated
| dispatch_action_config?: DispatchActionConfig; | ||
| } | ||
|
|
||
| export interface UsersSelect extends Action, Confirmable, Focusable, Placeholderable { |
Co-authored-by: Sarah Jiang <sarahjiang@slack-corp.com>
mwbrooks
approved these changes
Oct 28, 2022
Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>
zimeg
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to have a set of interfaces that other Block Kit elements can extend from easily.
This PR also starts adding some of the documentation hints from api.slack.com as JSDoc comments.
It is a small refactor, but it is especially helpful when documenting properties, as then they can be documented in one place but used in many places.
Let me know what you think! Like/dislike/don't care?