Upgrade dependency to @slack/types #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zimeg
added
semver:minor
enhancement
zimeg
approved these changes
Nov 20, 2022
There was a problem hiding this comment.
Hi @ClementValot, thanks for sending in this upgrade and signing the CLA! We'll make sure these new types are found in the next release!
|
This is still a problem. Doesn't build with @slack/types below 2.6 even though package.json states ^2.0.0 |
|
I unfortunately don't have the rights to merge @e-zim should you be the one to do that? 🙏 |
|
@ClementValot Sure thing! Didn't realize there were merge access restrictions, my bad! |
|
This is now live in v6.9.0 on npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade dependency to @slack/types since type MessageMetaData (available in types ^2.6.0) is required