Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability in ws@5.2.3 #1590

Closed
6 tasks
gamboaa opened this issue Feb 21, 2023 · 2 comments
Closed
6 tasks

Vulnerability in ws@5.2.3 #1590

gamboaa opened this issue Feb 21, 2023 · 2 comments
Assignees
Labels
pkg:rtm-api applies to `@slack/rtm-api`
Milestone

Comments

@gamboaa
Copy link

gamboaa commented Feb 21, 2023

(Describe your issue and goal here)

Packages:

Select all that apply:

  • @slack/web-api
  • [x ] @slack/rtm-api
  • @slack/webhooks
  • @slack/oauth
  • @slack/socket-mode
  • @slack/types
  • I don't know

Requirements

The direct dependency on ws@5.2.3 introduces a vulnerability

CVE-2021-32640 

ws is an open source WebSocket client and server library for Node.js. A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server. The vulnerability has been fixed in ws@7.4.6 (websockets/ws@00c425e). In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

@hello-ashleyintech hello-ashleyintech added pkg:rtm-api applies to `@slack/rtm-api` and removed untriaged labels Feb 22, 2023
@hello-ashleyintech hello-ashleyintech self-assigned this Feb 22, 2023
@hello-ashleyintech
Copy link
Contributor

Hi, @gamboaa! Thanks so much for submitting this notice! 😄

It looks like we had a PR from a while ago to update the ws base version to ws@7.5.3 in the @slack/rtm-api package, but it looks like it was never released. I am going to re-verify with my team to make sure this is good to release, and if so, I'll release a version with the updated ws base version! 🙌

@hello-ashleyintech
Copy link
Contributor

@gamboaa thanks again for flagging this! A new @slack/rtm-api version, v6.1.0, has been released that addresses this security update. You can view the release notes here!

Since this is resolved, I will be closing this issue out, but if anything else comes up then please feel free to file another issue! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:rtm-api applies to `@slack/rtm-api`
Projects
None yet
Development

No branches or pull requests

2 participants