Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide some context with rate-limited event #1636

Closed
1 of 7 tasks
levenleven opened this issue Jul 30, 2023 · 1 comment · Fixed by #1637
Closed
1 of 7 tasks

Provide some context with rate-limited event #1636

levenleven opened this issue Jul 30, 2023 · 1 comment · Fixed by #1637
Labels
enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api`
Milestone

Comments

@levenleven
Copy link
Contributor

levenleven commented Jul 30, 2023

Currently it is sometimes challenging to debug rate-limited events and handle them in single place, especially when multiple APIs calls are being done simultaneously. The only provided parameter is retrySec:

this.emit(WebClientEvent.RATE_LIMITED, retrySec);

Would be much more convenient if it would include api endpoint and parameters (e.g. channel in case of chat.postMessage)

Packages:

Select all that apply:

  • @slack/web-api
  • @slack/rtm-api
  • @slack/webhooks
  • @slack/oauth
  • @slack/socket-mode
  • @slack/types
  • I don't know

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` and removed untriaged labels Jul 31, 2023
@seratch seratch added this to the web-api@6.9.0 milestone Jul 31, 2023
@filmaj
Copy link
Contributor

filmaj commented Aug 2, 2023

Thanks for filing this and sending a PR implementing this! This is now live in v6.9.0 on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api`
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants