Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop use of deprecated interfaces and use new aliased one. #1664

Merged
merged 1 commit into from Sep 28, 2023
Merged

Drop use of deprecated interfaces and use new aliased one. #1664

merged 1 commit into from Sep 28, 2023

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Sep 26, 2023

Summary

Internally within the types package, drop use of the deprecated interfaces Action and Confirm in favour of newer terms: Actionable and ConfirmationDialog.

@filmaj filmaj added semver:patch enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` labels Sep 26, 2023
@filmaj filmaj added this to the types@2.9.0 milestone Sep 26, 2023
@filmaj filmaj requested a review from a team September 26, 2023 18:48
@filmaj filmaj self-assigned this Sep 26, 2023
srajiang
srajiang approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filmaj filmaj merged commit 208c53f into main Sep 28, 2023
15 checks passed
@filmaj filmaj deleted the types-use-new-aliases branch September 28, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srajiang srajiang srajiang approved these changes

Assignees

@filmaj filmaj

Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` semver:patch
Projects
None yet
Milestone
types@2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filmaj @srajiang