Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new args to admin.users.list and update web API response types #1688

Merged
merged 1 commit into from Nov 2, 2023
Merged

Add new args to admin.users.list and update web API response types #1688

merged 1 commit into from Nov 2, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 2, 2023

Summary

This pull request adds two newly added options to https://api.slack.com/methods/admin.users.list

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` labels Nov 2, 2023
@seratch seratch added this to the web-api@7.0 milestone Nov 2, 2023
@seratch seratch self-assigned this Nov 2, 2023
@seratch
Copy link
Member Author

seratch commented Nov 2, 2023

@filmaj Do you have ETA for #1673? If it can take long (that's totally fine!), we may want to cherry-pick this change and cut a new release in 6.x series.

@seratch seratch requested a review from filmaj November 2, 2023 05:45
@filmaj
Copy link
Contributor

filmaj commented Nov 2, 2023

@seratch yes I believe it will take longer. I can merge this into a 6.x maintenance branch and release.

@filmaj
Copy link
Contributor

filmaj commented Nov 2, 2023

@seratch I have created a web-api-6.x branch based off the branch that we released 6.9.1. Can you change the target of this PR to that branch, please?

@filmaj
Copy link
Contributor

filmaj commented Nov 2, 2023

Please ignore my last comment! I will merge this into main and cherry-pick into web-api-6.x myself.

@filmaj filmaj merged commit f1d3be3 into slackapi:main Nov 2, 2023
15 checks passed
@filmaj filmaj modified the milestones: web-api@7.0, web-api@6.10 Nov 2, 2023
filmaj pushed a commit that referenced this pull request Nov 2, 2023
@seratch @filmaj
Add new args to admin.users.list and update web API response types (#…
6e07903 
…1688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmaj filmaj filmaj approved these changes

Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api`
Projects
None yet
Milestone
web-api@6.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seratch @filmaj