Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Axios web-api to 1.6.3 #1710

Merged
merged 1 commit into from Jan 2, 2024
Merged

Upgrade Axios web-api to 1.6.3 #1710

merged 1 commit into from Jan 2, 2024

Conversation

hello-ashleyintech
Copy link
Contributor

Summary

Fixes issue #1709

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech mentioned this pull request Dec 29, 2023
Closed
7 tasks
seratch
seratch approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@seratch seratch added security pkg:web-api applies to `@slack/web-api` labels Dec 30, 2023
@seratch
Copy link
Member

seratch commented Dec 30, 2023

webhook project needs the same upgrade: https://github.com/slackapi/node-slack-sdk/blob/main/packages/webhook/package.json#L45

@seratch seratch added this to the web-api@7.0 milestone Dec 30, 2023
@filmaj
Copy link
Contributor

filmaj commented Jan 2, 2024

If we merge this change into main, then it will be released when we release the new major version (v7).

In addition, we can also merge/cherry-pick into the web-api-6.x branch and release as a patch release for the 6.x version series.

@filmaj filmaj merged commit 457ce38 into main Jan 2, 2024
15 checks passed
@filmaj filmaj deleted the ah-upgrade-axios branch January 2, 2024 19:31
@filmaj
Copy link
Contributor

filmaj commented Jan 2, 2024

I will cherry-pick this into web-api-6.x and do a 6.x release shortly with this fix as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

@filmaj filmaj filmaj approved these changes

@helzahalim helzahalim helzahalim approved these changes

Assignees

@hello-ashleyintech hello-ashleyintech

Labels
pkg:web-api applies to `@slack/web-api` security
Projects
None yet
Milestone
web-api@7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hello-ashleyintech @seratch @filmaj @helzahalim