Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep for new major version of oauth library #1727

Merged
merged 1 commit into from Jan 18, 2024
Merged

Prep for new major version of oauth library #1727

merged 1 commit into from Jan 18, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jan 18, 2024

  • Bump minimum required node version to 18 (warrants a major version bump)
  • Update unit test run script to print out project coverage
  • Make sure npm test runs the build to ensure there are no typescript compilation issues
  • Bump various dependencies to latest versions (including web-api to latest major version, which requires one small update to the auth.test API call)
  • Drop a few unused dev dependencies (nop, superagent, and uncaughtException)

@filmaj
oauth: bump min node version to 18, update unit test run script to pr…
2311951 
…int out coverage, bump dependencies to latest versions (including web-api to new major version), drop nop, superagent and uncaughtException dev dependencies that were unusued
@filmaj filmaj added semver:major pkg:oauth applies to `@slack/oauth-helper` labels Jan 18, 2024
@filmaj filmaj added this to the oauth@3.0.0 milestone Jan 18, 2024
@filmaj filmaj requested a review from a team January 18, 2024 14:52
@filmaj filmaj self-assigned this Jan 18, 2024
hello-ashleyintech
hello-ashleyintech approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@filmaj filmaj merged commit babcec5 into main Jan 18, 2024
15 checks passed
@filmaj filmaj deleted the oauth-major-prep branch January 18, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hello-ashleyintech hello-ashleyintech hello-ashleyintech approved these changes

Assignees

@filmaj filmaj

Labels
pkg:oauth applies to `@slack/oauth-helper` semver:major
Projects
None yet
Milestone
oauth@3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filmaj @hello-ashleyintech