Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing 'new' keyword in rate limit error throwing #1755

Merged
merged 1 commit into from Mar 12, 2024

Conversation

WhiteKiwi
Copy link
Contributor

Summary

Although both expressions work in JavaScript, the standard practice is to use new when instantiating error objects to ensure proper behavior and readability. This change, while not affecting functionality, aligns our code with conventional JavaScript practices.

Requirements (place an x in each [ ])

Copy link

Thanks for the contribution! Before we can merge this, we need @WhiteKiwi to sign the Salesforce Inc. Contributor License Agreement.

@seratch seratch added semver:patch pkg:web-api applies to `@slack/web-api` labels Mar 12, 2024
@seratch seratch added this to the web-api@7.0.3 milestone Mar 12, 2024
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this PR! This improves the code consistency

@seratch seratch merged commit 8bff32f into slackapi:main Mar 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants