Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .d.ts to @slack/interactive-messages? #798

Closed
6 of 9 tasks
ryota-ka opened this issue Jun 4, 2019 · 2 comments
Closed
6 of 9 tasks

Adding .d.ts to @slack/interactive-messages? #798

ryota-ka opened this issue Jun 4, 2019 · 2 comments
Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality

Comments

@ryota-ka
Copy link

ryota-ka commented Jun 4, 2019

Description

I've made a very first version of type declaration of @slack/interactive-messages for my personal use.

  • Would it be nice if we had ambient type declaration file for @slack/interactive-messages?
  • If so,
    • Where should we put index.d.ts?
    • With which script should we put index.d.ts into dist/ directory?

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@clavin
Copy link
Contributor

clavin commented Jun 13, 2019

Sorry for taking so long to respond!

I was actually working on #799 (which converts the source of @slack/interactive-messages to TypeScript) when you created this issue, and I believe it should end up fixing this issue :).

I'm interested to see the index.d.ts typings you created, and I'm happy to add any types you came up with that enhance the package.

@clavin clavin added area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality labels Jun 13, 2019
@clavin
Copy link
Contributor

clavin commented Aug 6, 2019

#799 has since been merged, and version 1.2.0 of @slack/interactive-messages should include typings.

I'm closing this since there's now typings for this package. 🙂

@clavin clavin closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants