Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds friendlier config error messages to Greet and React example app #841

Merged
merged 4 commits into from Mar 25, 2021
Merged

Adds friendlier config error messages to Greet and React example app #841

merged 4 commits into from Mar 25, 2021

Conversation

aaronschachter
Copy link
Contributor

Summary

Outputs a readable error message instead of a stack trace per #818. Also adds a few minor cleanup tweaks:

  • Fixes a typo in README
  • Adds .env, storage dir, and EOL to .gitignore
  • Adds link to ngrok in README

Requirements (place an x in each [ ])

@@ -9,10 +9,26 @@ const SlackStrategy = require('@aoberoi/passport-slack').default.Strategy;
const http = require('http');
const express = require('express');

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: could we put this helper function at the bottom of the file (or even import it from another file)? i think having this so close to the top captures too much attention for a beginner who is coming here to learn about how to use the @slack/events-api package.

@aoberoi aoberoi added the docs M-T: Documentation work only label Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #841 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #841   +/-   ##
=======================================
  Coverage   95.73%   95.73%           
=======================================
  Files          12       12           
  Lines         680      680           
  Branches      145      145           
=======================================
  Hits          651      651           
  Misses         11       11           
  Partials       18       18
Flag Coverage Δ
#eventsapi 89.61% <ø> (ø) ⬆️
#interactivemessages 96.62% <ø> (ø) ⬆️
#webapi 98.5% <ø> (ø) ⬆️
#webhook 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b40af...44fb410. Read the comment docs.

@clavin clavin changed the base branch from master to main July 8, 2020 02:20
@seratch
Copy link
Member

seratch commented Mar 25, 2021

@aaronschachter Thanks a lot for your contribution and we are sorry for our extremely slow response here. Your revised changes look great to me. Let me merge this PR now.

@seratch seratch merged commit 6c7843b into slackapi:main Mar 25, 2021
@aaronschachter aaronschachter deleted the fix-issue-818 branch March 25, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants