Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

views.update method doesn't accept only external_id #1002

Closed
6 of 15 tasks
suyashgulati opened this issue Apr 26, 2020 · 1 comment
Closed
6 of 15 tasks

views.update method doesn't accept only external_id #1002

suyashgulati opened this issue Apr 26, 2020 · 1 comment
Assignees
@misscoded
Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api`

Comments

@suyashgulati
Copy link
Contributor

Description

The views.update method does not accept object with only external_id, as the documentation says it should accept but the typings don't allow it without view_id code reference.

Screen Shot 2020-04-27 at 3 06 56 AM

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Packages:

Select all that apply:

  • @slack/web-api
  • @slack/events-api
  • @slack/interactive-messages
  • @slack/rtm-api
  • @slack/webhooks
  • I don't know

Reproducible in:

package version: 2.0.0

node version: 12.13.1

OS version(s): MacOS 10.13.6

Steps to reproduce:

Expected result:

Should allow ViewsUpdateArguments with only external_id or view_id

Actual result:

Currently view_id is required argument which should not be the case

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.
@suyashgulati suyashgulati mentioned this issue Apr 26, 2020
Merged
2 tasks
@seratch seratch added area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api` labels Apr 27, 2020
@seratch
Copy link
Member

seratch commented Jun 9, 2020

As #1003 has been reverted, this issue is not yet fixed. https://github.com/slackapi/node-slack-sdk/blob/%40slack/web-api%405.10.0/packages/web-api/src/methods.ts#L991-L996

We should fix this issue in the next version - #1003 (comment)

@seratch seratch mentioned this issue Jun 14, 2020
Closed
16 tasks
@misscoded misscoded added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Oct 1, 2020
@misscoded misscoded mentioned this issue Nov 16, 2020
Merged
2 tasks
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misscoded misscoded

Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seratch @stevengill @misscoded @suyashgulati