Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0 beta: better name convention #108

Closed
acemtp opened this issue Jan 18, 2016 · 0 comments
Closed

2.0.0 beta: better name convention #108

acemtp opened this issue Jan 18, 2016 · 0 comments

Comments

@acemtp
Copy link
Contributor

acemtp commented Jan 18, 2016

in the constant file, we have:

  OPENING_WEBSOCKET: 'opening_ws',
  OPENED_WEBSOCKET: 'opened_ws',
  WS_CLOSE: 'ws_close',
  WS_ERROR: 'ws_error',

should be better to have:

  WS_OPENING: 'ws_opening',
  WS_OPENED: 'ws_opened',
  WS_CLOSE: 'ws_close',
  WS_ERROR: 'ws_error',
ghost pushed a commit that referenced this issue Jan 22, 2016
Updates the RTM Client lifecyle events to use more constant naming co…
d7f4e37 
…nventions

Fixes #108
@ghost ghost closed this as completed Jan 22, 2016
ghost pushed a commit that referenced this issue Feb 13, 2016
Updates the RTM Client lifecyle events to use more constant naming co…
9aed92c 
…nventions

Fixes #108
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acemtp