New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to confirm clientOptions get passed to web-api #1083
Comments
I will give this issue a shot 🤠 A question: is it expected that the If it is, then I can expand these tests to verify that the Thanks for any info! |
hmm. It seems like this code could use a bit of improvement. I think the second authResult in the section i highlighted should be moved into the if statement.
I don't think authResult should ever have to run more than once. |
@stevengill when you say "the second authResult in the section I highlighted", which one do you mean? I see three authResult constructions:
|
Move 472 to 475. The v2 user install flow. Being in that if statement would mean it would only run in the circumstance that it is a v2 app and no bot token (only user token). |
Description
For
@slack/oauth
,clientOptions
should be getting passed to@slack/web-api
. Lets add a test for this.What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)The text was updated successfully, but these errors were encountered: