Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fields of the type definition of conversations.list are missing. #1397

Closed
1 of 6 tasks
ryokohbato opened this issue Dec 5, 2021 · 1 comment · Fixed by #1398
Closed
1 of 6 tasks

Some fields of the type definition of conversations.list are missing. #1397

ryokohbato opened this issue Dec 5, 2021 · 1 comment · Fixed by #1398
Assignees
@seratch
Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:web-api applies to `@slack/web-api`
Milestone
web-api@6.6.0

Comments

@ryokohbato
Copy link

Packages:

Select all that apply:

  • @slack/web-api
  • @slack/rtm-api
  • @slack/webhooks
  • @slack/oauth
  • @slack/socket-mode
  • I don't know

I noticed that the type definition of conversations.list API is partly missing.
This may be a problem with java-slack-sdk, but I will write it here.

In ConversationsListResponse.ts, this may not be all, but some fields are missing, like user, is_user_deleted, and priority. As far as I can see from the docs, it seems that if is_im is true, i.e. in the case of direct message, these fields are included in the response.
@seratch seratch added area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented and removed untriaged labels Dec 6, 2021
@seratch
Copy link
Member

seratch commented Dec 6, 2021

Hi @ryokohbato, thanks for taking the time to report this issue! And you're right that the generated source data is not complete due to the issue on the Java SDK side. We'll resolve this issue in the next release.

@seratch seratch self-assigned this Dec 6, 2021
@seratch seratch added this to the web-api@6.6.0 milestone Dec 6, 2021
seratch added a commit to seratch/node-slack-sdk that referenced this issue Dec 6, 2021
@seratch
Fix slackapi#1397 Add missing properties in conversation.list API res…
1b68aaa 
…ponse
@seratch seratch mentioned this issue Dec 6, 2021
Merged
2 tasks
seratch added a commit that referenced this issue Dec 6, 2021
@seratch
Fix #1397 Add missing properties in conversation.list API response (#…
331aa7f 
…1398)
srajiang pushed a commit that referenced this issue Dec 10, 2021
@seratch @srajiang
Fix #1397 Add missing properties in conversation.list API response (#…
15507dd 
…1398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:web-api applies to `@slack/web-api`
Projects
None yet
Milestone
web-api@6.6.0
Development

Successfully merging a pull request may close this issue.

Fix #1397 Add missing properties in conversation.list API response seratch/node-slack-sdk
2 participants
@seratch @ryokohbato